Fix inference script and add a sanity check. #72
Merged
wmdietl merged 5 commits intotypetools:masterfrom May 29, 2018
Merged
Conversation
wmdietl
reviewed
Mar 19, 2018
|
|
||
| final CheckerMain checkerMain = new CheckerMain(InferenceOptions.checkerJar, options); | ||
| checkerMain.addToRuntimeClasspath(getInferenceRuntimeJars()); | ||
| checkerMain.addToClasspath(getInferenceRuntimeJars()); |
Member
There was a problem hiding this comment.
The naming seems a bit strange now. Do we actually need the runtime jars on both paths?
Isn't it enough to just have checker-qual.jar on the compilation classpath?
Member
Author
There was a problem hiding this comment.
There are qualifiers that are not in checker-qual.jar such as ostrusted.
Member
There was a problem hiding this comment.
We should add a checker-inference-qual.jar as the classpath dependency, instead of adding all runtime jars.
Can you add this as a comment here or open an issue?
Member
|
Sorry for not getting to this sooner. After #71 this has some merge issues. |
mernst
pushed a commit
to mernst/checker-framework-inference
that referenced
this pull request
Apr 4, 2018
…typetools#72) * Clean up createEquivalentVarConstranit method in VariableAnnotator. * Fix typo in javadoc. Removed outdate comments. * Raise an error if the annotation on the given type is neither VarAnno nor real qualifier.
Member
|
Thanks for the fixes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without these changes,
Issued the following errors:
Then after coping checker-qual.jar to the correct location: