Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
Improves Bitbucket event handling when the event actor is a bot (app_user), ensuring turn-tracking and Slack messaging behave sensibly when no real user email exists.
Changes:
- Added
users.BitbucketActorToEmailand updated workflows to use it, mappingapp_useractors to"bot". - Propagated
accountTypethrough Bitbucket ID→email resolution to avoid unnecessary Jira lookups for bots. - Updated Slack turn/reminder logic and messaging to ignore empty/
"bot"emails and render a “no one’s turn” message.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/users/bitbucket.go | Adds actor→email wrapper and bot mapping behavior for app_user. |
| pkg/users/bitbucket_test.go | Adds unit tests covering bot/app actors mapping to "bot". |
| pkg/bitbucket/workflows/pullrequest.go | Switches workflows to actor-based email resolution. |
| pkg/bitbucket/workflows/comment.go | Switches turn/activity updates to actor-based email resolution. |
| pkg/bitbucket/pull_requests.go | Uses actor-based email resolution during PR init; clarifies account filtering comment. |
| pkg/bitbucket/pull_requests_test.go | Updates test to use app_user type. |
| pkg/data/turns.go | Adds account type awareness to email lookup; modifies reset behavior for corrupted/missing turns files. |
| pkg/data/users.go | Treats "bot" email as non-user in SelectUserByEmail. |
| pkg/slack/pr_data.go | Skips empty/"bot" emails during reminder scan. |
| pkg/slack/commands/turns.go | Filters empty/"bot" emails and adds “no one’s turn” message path. |
| pkg/slack/commands/turns_test.go | Adds coverage for “no one’s turn” output when only invalid/bot emails are present. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.