GitHub Actions CI: Remove Zig in Python wheel release#315
Open
jayaddison wants to merge 1 commit intoua-parser:masterfrom
Open
GitHub Actions CI: Remove Zig in Python wheel release#315jayaddison wants to merge 1 commit intoua-parser:masterfrom
jayaddison wants to merge 1 commit intoua-parser:masterfrom
Conversation
The Zig toolchain functionality enabled here originates from a build workflow[1] in the `uap-rust` repository; as far as I can tell, Zig is not required when building and releasing the Python wheels. My understanding is that the `maturin-action` that installs the Zig dependencies would proceed[2] even if they cannot be installed, so I don't think that their failure would block the release process here. Even so, I think that software build processes should usually try to limit their build requirements to only what is necessary, so I'm offering this as a cleanup. Resolves ua-parser#312. [1] - ua-parser/uap-rust#3 [2] - https://github.com/PyO3/maturin-action/blob/04ac600d27cdf7a9a280dadf7147097c42b757ad/dist/index.js#L47396-L47407
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Zig toolchain functionality enabled here originates from a build workflow in the
uap-rustrepository; as far as I can tell, Zig is not required when building and releasing the Python wheels.My understanding is that the
maturin-actionthat installs the Zig dependencies would proceed even if they cannot be installed, so I don't think that their failure would block the release process here.Even so, I think that software build processes should usually try to limit their build requirements to only what is necessary, so I'm offering this as a cleanup.
Resolves #312.