build: install govulncheck via official action, drop tools module - #1580
Merged
Conversation
Removes the manual govulncheck installation from the Makefile and uses golang/govulncheck-action to provide the binary in CI instead, mirroring how golangci-lint is handled: the action only downloads, and `make lint` runs the scan. vulncheck is now a prerequisite of lint, so the separate CI step is gone. The action has no install-only mode, so `go-package: -version` is used to make its run step a no-op, the same trick as `args: --help` for golangci-lint. `make vulncheck` installs govulncheck itself if it isn't already on PATH, so it works on a clean checkout without a bootstrap step. The check is on PATH rather than a file in GOBIN so CI reuses the copy the action installed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1580 +/- ##
=======================================
Coverage 98.85% 98.85%
=======================================
Files 53 53
Lines 3047 3047
=======================================
Hits 3012 3012
Misses 35 35 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
moisesvega
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the manual govulncheck installation from the Makefile and uses golang/govulncheck-action to provide the binary in CI instead, mirroring how golangci-lint is handled: the action only downloads, and
make lintruns the scan. vulncheck is now a prerequisite of lint, so the separate CI step is gone.The action has no install-only mode, so
go-package: -versionis used to make its run step a no-op, the same trick asargs: --helpfor golangci-lint.make vulncheckinstalls govulncheck itself if it isn't already on PATH, so it works on a clean checkout without a bootstrap step. The check is on PATH rather than a file in GOBIN so CI reuses the copy the action installed.