Update logic for generating unions to include the type key#93
Merged
vicapow merged 1 commit intouber-web:masterfrom Aug 21, 2019
Merged
Update logic for generating unions to include the type key#93vicapow merged 1 commit intouber-web:masterfrom
vicapow merged 1 commit intouber-web:masterfrom
Conversation
alee8
approved these changes
Aug 21, 2019
alee8
left a comment
alee8
left a comment
There was a problem hiding this comment.
Looks good. I verified with our repo with hand-edit of the flow-type aligned with this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unions will include a type field with a string that matches the
selected type. This is useful for type refinement.