Allow overriding default CoroutineDispatcher for WorkerBinder calls#596
Merged
Conversation
FranAguilera
force-pushed
the
add_migration_api
branch
2 times, most recently
from
61a4bbb to
9cba3a5
Compare
FranAguilera
force-pushed
the
add_migration_api
branch
from
9cba3a5 to
7f150cb
Compare
FranAguilera
commented
Jun 14, 2023
FranAguilera
force-pushed
the
add_migration_api
branch
2 times, most recently
from
39afa0d to
169edf3
Compare
- Define a dispatchers to be used on the now deprecated WorkerBinder/Worker within RibCoroutineConfig
FranAguilera
force-pushed
the
add_migration_api
branch
from
169edf3 to
880bbb6
Compare
tyvsmith
approved these changes
Jun 16, 2023
tyvsmith
left a comment
tyvsmith
left a comment
Member
There was a problem hiding this comment.
Thanks for addressing the changes we discussed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
WorkerBinder/Worker is going away in favor of RibCoroutineWorker. Still we would like to provide a mechanism to change the default CoroutineDispatcher being used at WorkerBinder.bind calls to be other than Unconfined.
This is given that the effective threading for binding those calls happens on the main thread, potentially leading to Jank, ANR, freezes, etc.
Related issue(s):
Current Workers being bound on Main thread.
Verification:
Verified on rib-workers demo app
Existing JUnit tests