Fix #848: Pass estimation_sample_size parameter to individual trees in UpliftRandomForestClassifier#850
Merged
jeongyoonlee merged 1 commit intouber:masterfrom Sep 26, 2025
Conversation
…es in UpliftRandomForestClassifier
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the estimation_sample_size parameter was not properly passed to individual trees in UpliftRandomForestClassifier. The fix enables correct honest splitting behavior when honesty=True.
- Stores the
estimation_sample_sizeparameter as an instance variable - Passes the parameter to individual
UpliftTreeClassifierinstances during forest creation
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jeongyoonlee
approved these changes
Sep 26, 2025
Collaborator
jeongyoonlee
left a comment
There was a problem hiding this comment.
LGTM. Thanks for your contribution, @mohsinm-dev!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #848 where the
estimation_sample_sizeparameter was not being passed to individual trees inUpliftRandomForestClassifier.Changes
UpliftRandomForestClassifier.__init__(line 2430)UpliftTreeClassifierinstances during forest creation (line 2481)Root Cause
The constructor accepted the
estimation_sample_sizeparameter but failed to:self.estimation_sample_size = estimation_sample_size)UpliftTreeClassifierinstances during forest creationImpact
This fix enables users to properly control honest splitting behavior in random forests when
honesty=True. Previously, all trees defaulted to 0.5 regardless of user specification.Testing
estimation_sample_sizevalues (0.1-0.9)Files Changed
causalml/inference/tree/uplift.pyx(2 line addition)