Our ./bin/check_format.sh script uses the system-installed clang-format version which seems to have varying behavior across versions. This makes it really hard for developers to ensure that their code will pass the CI format checks. Instead, the formatting and format check scripts should download a consistent clang-format version and not use the one installed by the system.
Our
./bin/check_format.shscript uses the system-installed clang-format version which seems to have varying behavior across versions. This makes it really hard for developers to ensure that their code will pass the CI format checks. Instead, the formatting and format check scripts should download a consistent clang-format version and not use the one installed by the system.