Skip to content

RPC container content fix#232

Merged
dcrankshaw merged 2 commits intoucbrise:developfrom
Corey-Zumar:rpc_fixes
Jun 27, 2017
Merged

RPC container content fix#232
dcrankshaw merged 2 commits intoucbrise:developfrom
Corey-Zumar:rpc_fixes

Conversation

@Corey-Zumar
Copy link
Contributor

@Corey-Zumar Corey-Zumar commented Jun 27, 2017

Fixes #231

flags=zmq.SNDMORE)
socket.send(self.msg_id, flags=zmq.SNDMORE)
socket.send(self.output_buffer[0:self.string_content_end_position])
event_history.insert(EVENT_HISTORY_SENT_CONTAINER_CONTENT)
Copy link
Contributor Author

@Corey-Zumar Corey-Zumar Jun 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This missing event history log did not contribute to #231 , but I've corrected the logging issue while addressing the bug.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/480/
Test PASSed.

@dcrankshaw dcrankshaw changed the title [CLIPPER-231] RPC container content fix RPC container content fix Jun 27, 2017
Copy link
Contributor

@dcrankshaw dcrankshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcrankshaw dcrankshaw merged commit 5de1fad into ucbrise:develop Jun 27, 2017
dcrankshaw pushed a commit that referenced this pull request Jun 27, 2017
* Fix RPC edge case

* Format code

(cherry picked from commit 5de1fad)
feynmanliang added a commit to feynmanliang/clipper that referenced this pull request Jul 3, 2017
* develop:
  Wording fix (ucbrise#234)
  RPC container content fix (ucbrise#232)
  [CLIPPER-227] Fix EWMA behavior for meters (ucbrise#228)
  One-line app registration and model deployment (ucbrise#223)
  R model deployment (ucbrise#195)
  Allow model versions to be strings (ucbrise#197)
  Base64 decoding for JSON byte data (ucbrise#214)
  Restarting on containers is no longer the default behavior (ucbrise#213)
  fixed backslash escape issue for removing remote containers (ucbrise#210)
  removed pip install findspark from run_unittests.sh (ucbrise#211)
  Fix example code in README (ucbrise#205)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants