Build new docker images in build_model with in-memory Dockerfile#280
Conversation
|
Test FAILed. |
|
jenkins test this please |
|
Test FAILed. |
|
Test PASSed. |
|
Test FAILed. |
|
Test PASSed. |
bf173b4 to
ce60e21
Compare
|
Test PASSed. |
Corey-Zumar
left a comment
There was a problem hiding this comment.
Looks good! Part two of the tutorial needs to be updated to remove the force argument from build_and_deploy_model. Once that's done, I'll merge.
|
Good catch. Fixed.
…On Sat, Sep 2, 2017 at 3:26 PM, Corey Zumar ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Looks good! Part two of the tutorial needs to be updated to remove the
force argument from build_and_deploy_model. Once that's done, I'll merge.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#280 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAaV5NGqTta0wAV8FCnoLedlp2sWTl1dks5sedYYgaJpZM4PKZet>
.
|
|
Test PASSed. |
Removes the need to write a Dockerfile to disk in the user's file system by creating an in-memory Dockefile with StringIO then adding it directly to a temporary tar file to be used as the Docker build context.
The end result is that we don't write (and potentially overwrite) Dockerfile's in the user's system.