Skip to content

Fix Issue with ClipperException and Docker not running case#308

Merged
dcrankshaw merged 6 commits intoucbrise:developfrom
simon-mo:develop
Nov 6, 2017
Merged

Fix Issue with ClipperException and Docker not running case#308
dcrankshaw merged 6 commits intoucbrise:developfrom
simon-mo:develop

Conversation

@simon-mo
Copy link
Contributor

@simon-mo simon-mo commented Nov 2, 2017

This PR fix issue #306 and #307.

It fixes #306 by adding a harmless __init__ method to
ClipperException, such that it has attribute msg.

It fixes #307 by catching requests.exception.ConnectionError and
raising a ClipperException, during the process of
DockerContainerManger(...).start_clipper().

@simon-mo
Fix broken links
0ba52db 
This PR fix issue @302. Update the link mentioned in warning messege
during python model deployment.

<Simon Mo>
@simon-mo
Merge branch 'develop' of https://github.com/ucbrise/clipper into dev…
f618e8f 
…elop
@simon-mo
Fix Issue with ClipperException and Docker not running case
06dd3c5 
This PR fix issue #306 and #307.

It fixes #306 by adding a harmless `__init__` method to
`ClipperException`, such that it has attribute `msg`.

It fixes #307 by catching `requests.exception.ConnectionError` and
raising a `ClipperException`, during the process of
`DockerContainerManger(...).start_clipper()`.

<Simon Mo>
@AmplabJenkins
Copy link

AmplabJenkins commented Nov 2, 2017

Can one of the admins verify this patch?

@dcrankshaw
Copy link
Contributor

dcrankshaw commented Nov 2, 2017

jenkins ok to test

dcrankshaw
dcrankshaw approved these changes Nov 2, 2017
View reviewed changes
Copy link
Contributor

@dcrankshaw dcrankshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It looks like there might be a Python formatting problem. Running ./bin/format_code.sh should fix it.

@AmplabJenkins
Copy link

AmplabJenkins commented Nov 2, 2017

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/764/
Test FAILed.

@dcrankshaw
Copy link
Contributor

dcrankshaw commented Nov 2, 2017

jenkins test this please

@AmplabJenkins
Copy link

AmplabJenkins commented Nov 2, 2017

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/765/
Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented Nov 6, 2017

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/766/
Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented Nov 6, 2017

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/767/
Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented Nov 6, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/768/
Test PASSed.

@dcrankshaw dcrankshaw merged commit e94219a into ucbrise:develop Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcrankshaw dcrankshaw dcrankshaw approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

No Error Message when Docker is not running 'ClipperException' object has no attribute 'msg'

3 participants

@simon-mo @AmplabJenkins @dcrankshaw