Skip to content

Support deploying Saved Tensorflow Models#328

Merged
dcrankshaw merged 2 commits intoucbrise:developfrom
santi81:tfServing
Jan 3, 2018
Merged

Support deploying Saved Tensorflow Models#328
dcrankshaw merged 2 commits intoucbrise:developfrom
santi81:tfServing

Conversation

@santi81
Copy link
Collaborator

@santi81 santi81 commented Nov 29, 2017

Current deployment of tensorflow models only supports deployment by passing the tensorflow session as a parameter.It should be possible to deploy any saved tensorflow model by passing the model directory path, like in the tfcifar example.This PR addresses the above issue.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@dcrankshaw
Copy link
Contributor

jenkins test this please

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/796/
Test PASSed.

@santi81
Copy link
Collaborator Author

santi81 commented Dec 3, 2017

@dcrankshaw supports serving Frozen tensor-flow models as well now. Can you pls review

Copy link
Contributor

@dcrankshaw dcrankshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcrankshaw
Copy link
Contributor

jenkins ok to test

if (len(is_frozen_graph) > 0):
os.makedirs(os.path.join(serialization_dir, "tfmodel"))
try:
shutil.copyfile(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kakru's suggestion

I'd suggest using copytree instead of copyfile to keep the behavior consistent between model types (cf. line 207). Possible problem might arise if there is more than one file in the saved_model_path (check is for >0) and only the first .pb file is copied

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/807/
Test PASSed.

@santi81
Copy link
Collaborator Author

santi81 commented Dec 11, 2017

@dcrankshaw fixed the issue based on comment from @kakru

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/812/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/813/
Test FAILed.

@santi81
Copy link
Collaborator Author

santi81 commented Dec 11, 2017

@dcrankshaw i guess the tests failed due to some other sporadic error.Can you please re-trigger the build.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/814/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/820/
Test PASSed.

@dcrankshaw dcrankshaw merged commit 362787f into ucbrise:develop Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants