Skip to content

R Support: Handle missing libraries#344

Merged
Corey-Zumar merged 1 commit intoucbrise:developfrom
Corey-Zumar:rlib_fix
Dec 14, 2017
Merged

R Support: Handle missing libraries#344
Corey-Zumar merged 1 commit intoucbrise:developfrom
Corey-Zumar:rlib_fix

Conversation

@Corey-Zumar
Copy link
Contributor

Adds error handling when deserializing and loading a model's library dependencies. If a library cannot be loaded, the container no longer crashes immediately. Instead, a warning message is emitted.

This fixes the issue where loading the Rclipper library into an R environment and calling Rclipper::build_model(...) causes the built container to crash on deployment due to the fact that Rclipper is not available for installation on CRAN.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/805/
Test FAILed.

@dcrankshaw
Copy link
Contributor

jenkins test this please

Copy link
Contributor

@dcrankshaw dcrankshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/806/
Test PASSed.

@Corey-Zumar Corey-Zumar merged commit dd9ce4f into ucbrise:develop Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants