Support for PyTorch model by Corey-Zumar · Pull Request #346 · ucbrise/clipper

Corey-Zumar · 2017-12-16T00:32:28Z

@haofanwang Added some updates to fix the class serialization issue and accidentally closed #322 in the process. Take a look and let me know if you have any questions.

This should be good to go once @dcrankshaw takes a final pass.

Fixes #343, #314

into pytorch_fixes

AmplabJenkins · 2017-12-16T00:45:39Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/815/
Test FAILed.

Corey-Zumar · 2017-12-16T00:49:08Z

clipper_admin/clipper_admin/deployers/cloudpickle.py

@@ -1,15 +1,20 @@
 """


Pulled the latest cloudpickle. This fixes issues with recursive dependencies that caused issues when serializing pytorch models.

If we're replacing Cloudpickle, let's just switch to using the cloudpickle pip package (pip install cloudpickle).

Corey-Zumar · 2017-12-16T00:50:15Z

clipper_admin/clipper_admin/deployers/pytorch.py

+                                        PYTORCH_MODEL_RELATIVE_PATH)
+
+    try:
+        torch.save(pytorch_model.state_dict(), torch_weights_save_loc)


We now save the model weights and class definition separately. Weights are saved via PyTorch, and the class is pickled with CloudPickle

AmplabJenkins · 2017-12-16T01:34:20Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/816/
Test PASSed.

dcrankshaw

Two small changes then this is good to go. @Corey-Zumar can you go ahead and make those?

dcrankshaw · 2018-01-03T21:21:39Z

clipper_admin/clipper_admin/deployers/cloudpickle.py

@@ -1,15 +1,20 @@
 """


If we're replacing Cloudpickle, let's just switch to using the cloudpickle pip package (pip install cloudpickle).

dcrankshaw · 2018-01-03T21:31:22Z

dockerfiles/PyTorchContainerDockerfile

+      && apt-get update --fix-missing \
+      && apt-get install -yqq -t jessie-backports openjdk-8-jdk \
+      && conda install -y --file /lib/python_container_conda_deps.txt \
+      && conda install pytorch torchvision -c soumith


They created a PyTorch conda channel recently, so this should be conda install pytorch torchvision -c pytorch

AmplabJenkins · 2018-01-08T23:03:39Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/833/
Test FAILed.

AmplabJenkins · 2018-01-08T23:41:05Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/834/
Test FAILed.

AmplabJenkins · 2018-01-09T02:31:16Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/835/
Test FAILed.

AmplabJenkins · 2018-01-09T03:37:51Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/838/
Test FAILed.

AmplabJenkins · 2018-01-09T07:31:40Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/839/
Test FAILed.

AmplabJenkins · 2018-01-09T10:49:05Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/840/
Test FAILed.

Corey-Zumar · 2018-01-10T00:19:29Z

jenkins test this please

AmplabJenkins · 2018-01-10T01:14:51Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/844/
Test FAILed.

AmplabJenkins · 2018-01-10T02:10:29Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/845/
Test PASSed.

dcrankshaw

lgtm

haofanwang and others added 23 commits November 20, 2017 15:44

Add files via upload

2256349

Add files via upload

5a7bda9

Add files via upload

261f67a

Update build_docker_images.sh

512f126

Update pytorch.py

3afa439

Update pytorch_container.py

6f74280

Add files via upload

cd259a3

Add files via upload

1591ab7

Create deploy_pytorch_models.py

5501c95

Update deploy_pytorch_models.py

f7e2fbe

Update deploy_pytorch_models.py

cf849f9

Update deploy_pytorch_models.py

fa5aecd

Update deploy_pytorch_models.py

acd9675

Update deploy_pytorch_models.py

932df78

Update pytorch.py

a00d527

Update deploy_pytorch_models.py

b38c388

Update deploy_pytorch_models.py

1101f16

Update deploy_pytorch_models.py

0abd22b

Update pytorch_container.py

b5411c2

Update deploy_pytorch_models.py

6022a6b

Update deploy_pytorch_models.py

b9a309e

Merge branch 'develop' into HEAD

3073a06

Capture class dependencies

f9bc385

Corey-Zumar requested review from dcrankshaw and haofanwang December 16, 2017 00:32

Corey-Zumar added 4 commits December 15, 2017 16:32

Merge branch 'develop' into pytorch_fixes

8a5c462

remove prints

7fbfe08

Merge branch 'pytorch_fixes' of https://github.com/Corey-Zumar/clipper-1

d771b45

into pytorch_fixes

Format code

d0bd57b

Corey-Zumar commented Dec 16, 2017

View reviewed changes

dcrankshaw requested changes Jan 3, 2018

View reviewed changes

dcrankshaw added status: needs revision and removed status: needs review labels Jan 3, 2018

Corey-Zumar added 2 commits January 8, 2018 14:46

Address review comments

5676159

Format code

39452ea

Corey-Zumar added status: needs review type: enhancement and removed status: needs revision labels Jan 8, 2018

Corey-Zumar added 2 commits January 8, 2018 17:45

Fix container imports

d8c3f72

Correct print statement typo in closure container

5505844

Corey-Zumar mentioned this pull request Jan 9, 2018

Error in deploying Python function which uses Cython #347

Closed

Fix merge conflicts with tf container

2fa4ffa

Format code

6abf926

Don't install clipper_admin where only cloudpickle is needed

8072579

Add missing cloudpickle dependency in tests file

7210bdf

dcrankshaw approved these changes Jan 10, 2018

View reviewed changes

dcrankshaw merged commit 3b44a91 into ucbrise:develop Jan 10, 2018

Corey-Zumar mentioned this pull request Jan 18, 2018

Implement a model deployer for PyTorch #314

Closed

Conversation

Corey-Zumar commented Dec 16, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AmplabJenkins commented Dec 16, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AmplabJenkins commented Dec 16, 2017

Uh oh!

dcrankshaw left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AmplabJenkins commented Jan 8, 2018

Uh oh!

AmplabJenkins commented Jan 8, 2018

Uh oh!

AmplabJenkins commented Jan 9, 2018

Uh oh!

AmplabJenkins commented Jan 9, 2018

Uh oh!

AmplabJenkins commented Jan 9, 2018

Uh oh!

AmplabJenkins commented Jan 9, 2018

Uh oh!

Corey-Zumar commented Jan 10, 2018

Uh oh!

AmplabJenkins commented Jan 10, 2018

Uh oh!

AmplabJenkins commented Jan 10, 2018

Uh oh!

dcrankshaw left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Corey-Zumar commented Dec 16, 2017 •

edited

Loading