Skip to content

Fix a bug that ManagementFrontend adds a garbage to http response#582

Merged
simon-mo merged 3 commits intoucbrise:developfrom
withsmilo:fix_mgnt_frontend_bug
Mar 28, 2019
Merged

Fix a bug that ManagementFrontend adds a garbage to http response#582
simon-mo merged 3 commits intoucbrise:developfrom
withsmilo:fix_mgnt_frontend_bug

Conversation

@withsmilo
Copy link
Collaborator

Currently ManagementFrontend sends ['http header' + 'content' + '\n'] as a http response to the outer side. Our team found some error cases occurred by wrong value(content.length()) of Content-Length in the 'http header'. To fix it, \n must be removed from the http response.

I found the same bug in QueryFrontend and pull-requested it already. (#415)

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@jvdmeulen92
Copy link

jenkins test this please

@withsmilo withsmilo self-assigned this Dec 3, 2018
@simon-mo
Copy link
Contributor

Jenkins ok to test

@simon-mo
Copy link
Contributor

Jenkins test this please

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1775/
Test FAILed.

@withsmilo
Copy link
Collaborator Author

Jenkins test this please

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1778/
Test FAILed.

@withsmilo
Copy link
Collaborator Author

Jenkins test this please

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1779/
Test PASSed.

@withsmilo
Copy link
Collaborator Author

@simon-mo :
Why did first Jenkins job fail? Anyway, this pull request has finally passed Jenkins. Please merge this.

Copy link
Contributor

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simon-mo
Copy link
Contributor

@withsmilo thanks, i just rebased it, I will merge this once the test passes again. I understand the tests are still flaky. I will take care of it.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1786/
Test FAILed.

@withsmilo
Copy link
Collaborator Author

Jenkins test this please

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1810/
Test FAILed.

Sungjun, Kim added 2 commits March 22, 2019 12:52
Currently ManagementFrontend sends ['http header' + 'content' + '\n'] as a http response to the outer side.
Our team found some error cases occurred by wrong value(content.length()) of Content-Length in the 'http header'.
To fix it, '\n' must be removed from the http response.

I found the same bug in QueryFrontend and pull-requested it already. (ucbrise#415)
@withsmilo withsmilo force-pushed the fix_mgnt_frontend_bug branch from aace07f to 524fb0b Compare March 22, 2019 03:53
@withsmilo
Copy link
Collaborator Author

Jenkins test this please

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1812/
Test PASSed.

@withsmilo withsmilo requested review from RehanSD and simon-mo March 22, 2019 05:09
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1849/
Test PASSed.

@simon-mo simon-mo merged commit 4981f42 into ucbrise:develop Mar 28, 2019
@withsmilo withsmilo deleted the fix_mgnt_frontend_bug branch March 28, 2019 08:35
rkooo567 pushed a commit to rkooo567/clipper that referenced this pull request Apr 27, 2019
…brise#582)

* Fix a bug that ManagementFrontend adds a garbage to http response

Currently ManagementFrontend sends ['http header' + 'content' + '\n'] as a http response to the outer side.
Our team found some error cases occurred by wrong value(content.length()) of Content-Length in the 'http header'.
To fix it, '\n' must be removed from the http response.

I found the same bug in QueryFrontend and pull-requested it already. (ucbrise#415)

* Add a timer to container_test
rkooo567 pushed a commit to rkooo567/clipper that referenced this pull request Apr 28, 2019
…brise#582)

* Fix a bug that ManagementFrontend adds a garbage to http response

Currently ManagementFrontend sends ['http header' + 'content' + '\n'] as a http response to the outer side.
Our team found some error cases occurred by wrong value(content.length()) of Content-Length in the 'http header'.
To fix it, '\n' must be removed from the http response.

I found the same bug in QueryFrontend and pull-requested it already. (ucbrise#415)

* Add a timer to container_test
rkooo567 pushed a commit to rkooo567/clipper that referenced this pull request Apr 28, 2019
…brise#582)

* Fix a bug that ManagementFrontend adds a garbage to http response

Currently ManagementFrontend sends ['http header' + 'content' + '\n'] as a http response to the outer side.
Our team found some error cases occurred by wrong value(content.length()) of Content-Length in the 'http header'.
To fix it, '\n' must be removed from the http response.

I found the same bug in QueryFrontend and pull-requested it already. (ucbrise#415)

* Add a timer to container_test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants