Skip to content

change set_num_replicas in docker_container_manager #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simon-mo merged 5 commits into from
Mar 28, 2019
Merged

change set_num_replicas in docker_container_manager #616

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
547329c
change set_num_replicas in docker_container_manager, due to - Attribu…
Jan 29, 2019
993336a
revise set_num_replicas logic
Jan 29, 2019
2e57b89
changed 'container' to 'inspect_container'
Jan 30, 2019
6ca1f4c
Merge branch 'develop' into develop
Evan-JH-Kim Mar 24, 2019
85b508b
Merge branch 'develop' into develop
Evan-JH-Kim Mar 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions clipper_admin/clipper_admin/docker/docker_container_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,8 +362,13 @@ def set_num_replicas(self, name, version, input_type, image, num_replicas):
model_container_names.append(container_name)
for name in model_container_names:
container = self.docker_client.containers.get(name)
while container.attrs.get("State").get("Status") != "running" or \
self.docker_client.api.inspect_container(name).get("State").get("Health").get("Status") != "healthy":
while True:
state = container.attrs.get("State")
inspect_container = self.docker_client.api.inspect_container(name)
if (state is not None and state.get("Status") == "running") or \
(inspect_container is not None and
inspect_container.get("State").get("Health").get("Status") == "healthy"):
break
time.sleep(3)

elif len(current_replicas) > num_replicas:
Expand Down