Retry when docker push fails#662
Conversation
withsmilo
commented
Mar 28, 2019
withsmilo
commented
- related issue : no.7 in [CI] Bug report #656
- I imported a Retry decorator from https://www.saltycrane.com/blog/2009/11/trying-out-retry-decorator-python.
* I imported a Retry decorator from https://www.saltycrane.com/blog/2009/11/trying-out-retry-decorator-python.
|
This looks great. We have several cases of sleep and retry in clipper_admin, do you want to refactor them as well in this PR? |
|
@simon-mo |
|
Test PASSed. |
| raise e | ||
|
|
||
| # Wait for maximum 5 min. | ||
| @retry(RequestException, tries=300, delay=1, backoff=1, logger=self.logger) |
There was a problem hiding this comment.
Yes. 5min is reasonable. We might want to increase the interval later if it prints too much intonations to the console. However, current interval looks good enough.
|
Test PASSed. |
|
Test PASSed. |
* Retry when docker push fails * I imported a Retry decorator from https://www.saltycrane.com/blog/2009/11/trying-out-retry-decorator-python. * Apply new Retry decorator to start_clipper()
* Retry when docker push fails * I imported a Retry decorator from https://www.saltycrane.com/blog/2009/11/trying-out-retry-decorator-python. * Apply new Retry decorator to start_clipper()
* Retry when docker push fails * I imported a Retry decorator from https://www.saltycrane.com/blog/2009/11/trying-out-retry-decorator-python. * Apply new Retry decorator to start_clipper()
3 participants
