[CI] Randomize RPCService's port and handle NoSuchProcess error properly#690
Conversation
We should avoid the port collisions between test cases as much as possible. https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1934/ shows the port collision to us.
|
Test FAILed. |
|
Test FAILed. |
Current Jenkins CI shows the following errors to us. ``` [unittest_rpc_container] Traceback (most recent call last): [unittest_rpc_container] File ../python/rpc_test_container.py, line 1, in <module> [unittest_rpc_container] import rpc [unittest_rpc_container] File /clipper/containers/python/rpc.py, line 20, in <module> [unittest_rpc_container] import clipper_admin.metrics as metrics [unittest_rpc_container] File /clipper/clipper_admin/clipper_admin/metrics/__init__.py, line 6, in <module> [unittest_rpc_container] if not server.redis_daemon_exist(): [unittest_rpc_container] File /clipper/clipper_admin/clipper_admin/metrics/server.py, line 134, in redis_daemon_exist [unittest_rpc_container] process_names = [psutil.Process(pid).name() for pid in pids] [unittest_rpc_container] File /usr/local/lib/python2.7/dist-packages/psutil/__init__.py, line 338, in __init__ [unittest_rpc_container] self._init(pid) [unittest_rpc_container] File /usr/local/lib/python2.7/dist-packages/psutil/__init__.py, line 378, in _init [unittest_rpc_container] raise NoSuchProcess(pid, None, msg) [unittest_rpc_container] psutil._exceptions.NoSuchProcess: psutil.NoSuchProcess no process found with pid 162 ```
|
Test FAILed. |
|
Test FAILed. |
09f5c6e to
691e67e
Compare
|
Test PASSed. |
|
Test PASSed. |
|
Please review this PR. 😬 |
|
@rkooo567 Thank you! 😊 |
This PR contains two parts.
We should avoid the port collisions between test cases as much as possible.