Update SimpleWebServer to the latest version(29 Apr, 2019 - d6985ed6)#691
Conversation
|
Test FAILed. |
|
Test PASSed. |
rkooo567
left a comment
There was a problem hiding this comment.
Thank you for the PR! I appreciate you added [CLIPPER] comment line so that we can easily update the part whenever we update this dependency.
Everything looks good to me, but I have a few questions.
- Aren't we using C++ formatter anymore? I found some parts of code were formatted in the previous SimpleWebServer V2.1.1.
- This version (d6985) is literally the newest commit of SimpleWebServer. Do you think it is stable enough? I am afraid we have to keep updating the version because the newest master is unstable. Is it the version your team is currently using?
| }; | ||
|
|
||
| public: | ||
| // [CLIPPER] |
There was a problem hiding this comment.
I found in the previous code, these were formatted (I believe we ran the formatter before?). We don't use the C++ formatter anymore? @simon-mo @withsmilo
|
| SOFTWARE. | ||
| */ | ||
|
|
||
| #ifndef SERVER_HTTP_HPP |
There was a problem hiding this comment.
Why don't we add a README.md to record the version/revision hash information? Seems like some C++ dependencies keep track of its version in its directory name, but httpserver does not. I believe it is because we have some additional custom code inside. We can also probably mention whenever we update the version of httpserver, we should remain the parts with // [CLIPPER].
|
Thanks! I'll directly merge this one since test passed already. |
|
Test PASSed. |
Uh oh!
There was an error while loading. Please reload this page.