#692: Added get_metric_addr to the ClipperConnection#693
Merged
simon-mo merged 3 commits intoucbrise:developfrom May 14, 2019
Merged
#692: Added get_metric_addr to the ClipperConnection#693simon-mo merged 3 commits intoucbrise:developfrom
simon-mo merged 3 commits intoucbrise:developfrom
Conversation
|
Test FAILed. |
Collaborator
|
@rkooo567 |
Collaborator
Author
|
@withsmilo You are right. I will remove |
…nterface to communicate with management frontend. It is unncessary
withsmilo
changed the title
|
Test PASSed. |
Collaborator
Collaborator
Author
|
@withsmilo Sounds good! Thanks a lot for checking it out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #692
Summary
Currently
ClipperConnectionAPI does not includeget_admin_addr()andget_metric_addr(). I added these two functions to ClipperConnection.@simon-mo I believe our CI should automatically update our API docs once it is merged, but let me know if there are other steps to do to update API documentation. (http://docs.clipper.ai/en/v0.3.0/)