Print necessary stackstace information when crashed#700
Print necessary stackstace information when crashed#700withsmilo merged 2 commits intoucbrise:developfrom
Conversation
|
Test FAILed. |
|
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1975/ shows this error, |
|
Jenkins test this please |
|
Test FAILed. |
There was a problem hiding this comment.
LGTM in general! I still have a couple questions.
- How is it different from just using
docker logson a broken container? Is it for our CI environment? 2. I found this notes frombacktrace_symbols_fd
backtrace() and backtrace_symbols_fd() don't call malloc()
explicitly, but they are part of libgcc, which gets loaded
dynamically when first used. Dynamic loading usually triggers a
call to malloc(3). If you need certain calls to these two
functions to not allocate memory (in signal handlers, for
example), you need to make sure libgcc is loaded beforehand.
Are we loading libgcc beforehand? Is it already included in our compilation process?
EDIT -> Actually 2 might not matter because we print logs when containers are broken? Is docker container freeing all of its memory when it is broken?
|
@rkooo567
|
|
Test FAILed. |
|
Jenkins test this please |
|
Test PASSed. |
No description provided.