Update the version of base libraries and OS#714
Merged
simon-mo merged 7 commits intoucbrise:developfrom Jun 4, 2019
Merged
Conversation
added 2 commits
May 31, 2019 13:40
…folly(v2019.03.18.00)
I imported three files from https://github.com/Kitware/CMake/blob/7a8a24d0284856b7b38037884d0b17a1de7a9926/Modules/FindBoost.cmake. This FindBoost.cmake supports the latest version of Boost(1.70.0).
|
Test FAILed. |
|
Test FAILed. |
withsmilo
changed the title
|
Test PASSed. |
|
Test PASSed. |
withsmilo
changed the title
simon-mo
approved these changes
Jun 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. related issue
#583, #551
2. Change the base OS from
debian:stretch-slimtoubuntu:18.04in ClipperLibBaseDockerfiledebian:stretch-slim uses libboost-all-dev (1.62.0.1) (link), but I have suffered with the 'epoll_reactor' bug of Boost in the production environment, and this bug was resolved by Boost 1.65.0. (link)
To avoid this bug, we changed the base OS from debian:stretch-slim to ubuntu:18.04, in which we can install libboost-all-dev (1.65.1) easily. (link) The sizes of the two Docker images are similar.
3. Update folly from
v2017.08.14.00tov2019.03.18.00It's difficult to determine what version is stable because folly is released by weekly. So I will try to apply the 2019.03.18.00 version first of all, which is the latest in brew.
4. Update FindBoost.cmake to support the latest version of Boost(1.70.0)
5. We can finally build the Clipper on Mac OS using the methods on this site.