Handle trailing slash on predict url#721
Merged
rkooo567 merged 4 commits intoucbrise:developfrom Jun 5, 2019
Merged
Conversation
Collaborator
withsmilo
commented
Jun 4, 2019
withsmilo
commented
- related issue : Deal with trailing slash on predict url #576
|
Test FAILed. |
rkooo567
reviewed
Jun 4, 2019
| self.assertNotEqual(parsed_response["output"], self.default_output) | ||
| self.assertFalse(parsed_response["default"]) | ||
|
|
||
| def test_deployed_model_queried_with_training_slash_successfully(self): |
Collaborator
There was a problem hiding this comment.
Why don't we add a check in test_test_predict_function instead of creating a new test?
Collaborator
Author
There was a problem hiding this comment.
Good. I was thinking a little bit about whether to add a new test.
|
Test PASSed. |
|
Test PASSed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.