Change header include paths to be relative#3
Open
remaininlight wants to merge 1 commit intoultralight-ux:masterfrom
Open
Change header include paths to be relative#3remaininlight wants to merge 1 commit intoultralight-ux:masterfrom
remaininlight wants to merge 1 commit intoultralight-ux:masterfrom
Conversation
remaininlight
changed the title
remaininlight
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm in the process of making a library which integrates Ultralight with JUCE (an audio framework). It would be good if users don't have to modify their include paths when the use this, JUCE has a module system to manage 3rd party code which I'm hooking into.
The include paths in these Ultralight headers currently require them to all be on the main include path for it to work, this PR proposes changing them to be relative imports - which should work whether Ultralight is on the include path or not.