Skip to content

GroupId conditions - js error fix for undefined permission checks #22653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
steveatkiss wants to merge 1 commit into
base: main
Choose a base branch
from
Open

GroupId conditions - js error fix for undefined permission checks #22653

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...co.Web.UI.Client/src/packages/user/current-user/conditions/group-id/group-id.condition.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,12 @@ export class UmbCurrentUserGroupCondition
}

#observeCurrentUser = async (currentUser: UmbCurrentUserModel) => {
// If currentUser is not yet available, return early to avoid errors
if (!currentUser) {
this.permitted = false;
return;
}

// Idea: This part could be refactored to become a shared util, to align these matching feature across conditions. [NL]
// Notice doing so it would be interesting to invistigate if it makes sense to combine some of these properties, to enable more specific matching. (But maybe it is only relevant for the combination of match + oneOf) [NL]
const { match, oneOf, allOf, noneOf } = this.config;
Expand Down
Loading