-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Recognize Radeon 8065S (Gorgon Halo / Ryzen AI Max 400) as gfx1151 #7290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
2c7673e
f3c9bab
397a8ec
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -719,8 +719,8 @@ def _dedup_pick(tokens: list[str]) -> "str | None": | |
| _WIN_GPU_NAME_ARCH_TABLE: "list[tuple[str, str]]" = [ | ||
| (r"9070 XT|9080", "gfx1201"), # RDNA 4 (Radeon RX 9070 XT / 9080) | ||
| (r"9070|9060", "gfx1200"), # RDNA 4 (Radeon RX 9070 / 9060) | ||
| # RDNA 3.5 (Strix Halo: Radeon 8060S/8050S/8040S iGPU, Ryzen AI Max+) | ||
| (r"8060S|8050S|8040S|Strix Halo|Ryzen AI Max|AI Max", "gfx1151"), | ||
| # RDNA 3.5 (Strix Halo + Gorgon Halo: Radeon 8065S/8060S/8050S/8040S iGPU, Ryzen AI Max / Max+) | ||
| (r"8065S|8060S|8050S|8040S|Strix Halo|Ryzen AI Max|AI Max", "gfx1151"), | ||
|
Comment on lines
+722
to
+723
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When a Radeon wheel omits both Useful? React with 👍 / 👎.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed in f3c9bab: added There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
On Windows hosts that reach this marketing-name fallback (no directly reported HIP/amd-smi arch), this mapping selects AMD's Useful? React with 👍 / 👎.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same concern as the thread above, and the blocking objection still stands. 8065S and 8060S resolve to the identical The gfx1151 selection is a |
||
| # RDNA 3.5 (Strix/Krackan Point: Radeon 890M/880M iGPU, Ryzen AI 9 HX 370/375) | ||
| ( | ||
| r"890M|880M|860M|840M|Strix Point|Krackan|HX 37[05]|AI 9 HX|AI 9 36[05]" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a driver-only host this new fallback selects the
gfx1151AMD index, whose installer paths constrain torch to the bundled ROCm 7.13 runtime. The commit notes that Gorgon Halo device support was only added in ROCm 7.14 and that an HSA override may be needed; without updating the runtime/index or setting that override, these newly recognized 8065S systems install ROCm torch that cannot enumerate the GPU, rather than the previous CPU fallback. Gate this mapping on a compatible runtime or add the required newer runtime/override handling.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8065S and 8060S resolve to the identical
gfx1151arch and the identical wheel: the name table returns only an arch string with no per-name runtime floor, and both flow through the samerepo.amd.com/rocm/whl/gfx1151/path that already ships for Strix Halo 8060S. So gating this mapping on a compatible runtime cannot target 8065S without also gating 8060S, which is the currently working, already shipped config.The wheel is not pinned to 7.13. gfx1151 uses the floor
torch>=2.11.0,<2.12.0against the per-arch index, which resolves totorch-2.11.0+rocm7.13.0today only because that is the sole 2.11 build on the index. ROCm 7.14 is now a production release adding Gorgon Halo enablement for the Ryzen AI Max PRO 495/490/485; when AMD publishes a2.11.x+rocm7.14wheel on that same per-arch channel, as they did across 7.9 through 7.13, pip selects it with no change here.On worse-than-before: a ROCm build on a device the runtime cannot enumerate still runs on CPU with
torch.cuda.is_available()False, which is no worse than the prior CPU fallback. The only genuinely worse mode,is_available()True with a GPU memory access fault, is a pre-existing gfx1151 runtime maturity issue that already affects the shipped 8060S on these same wheels (ROCm/legacy-rocm-build#5824, pytorch/pytorch#173367); it is not introduced by recognizing an additional marketing name. The newer-runtime / HSA override caveat is already noted in the PR description and is an AMD runtime detail independent of installer name inference. Keeping the mapping.