Conversation
Collaborator
|
majority of changes in hashtable and trace. misc changes elsewhere. majority of remaining _tmp usage to convert to 32/64-bit limited to jets |
Collaborator
|
recommend concurrent or after completion of _tmp conversions to run zig build with |
pkova
added a commit
that referenced
this pull request
May 23, 2025
Contributor
|
Closing in favor of #715. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces 64-bit Vere. The principle changes involved have to do with the introduction of a new type, c3_n, which is 32 bit or 64 bit depending on if it was compiled with -DVERE64.
The following work still needs to be done:
PMA integration (easy in vere64, vere32 requires more involved work)developfor mug: revendor murmur3 #840, do it in 2 commits (original vendor, our changes), include upstream commit hash in commit messageI will make this more granular and regularly update this as involved collaborators complete things.