Merged
Conversation
arnevandoorslaer
requested review from
BelgianNoise,
lem-onade,
wouteraj and
woutermont
2 tasks
woutermont
suggested changes
May 7, 2021
| ofType(shapesDetected), | ||
| mergeMap(({shapeIds}) => forkJoin(shapeIds.concat([ 'http://digita.ai/voc/input#input' ]).map((shapeId) => this.semComService.queryComponents(shapeId)))), | ||
| map((resultsPerShape) => resultsPerShape.filter((results) => results.length > 0)), | ||
| map((resultsPerShape) => resultsPerShape.filter((results) => results.length > 0 && results[0])), |
Contributor
There was a problem hiding this comment.
Instead of checking here, we should rewrite the query function to never return undefined.
|
|
||
| async query(filter: Partial<ComponentMetadata>): Promise<ComponentMetadata[]> { | ||
| return this.components.filter((component) => | ||
| let filtered = this.components.filter((component) => |
Contributor
There was a problem hiding this comment.
I would prefer this to remain a constant, e.g. by returning other constant based on this one.
Comment on lines
+25
to
+29
| if(filtered && filter.version) { | ||
| const versions = filtered.map((component) => component.version); | ||
| const maxVersion = semver.maxSatisfying(versions, filter.version); | ||
| filtered = [ filtered.find((component) => component.version === maxVersion) ]; | ||
| } |
Contributor
There was a problem hiding this comment.
Rewrite this so it does not return undefined (e.g. using filter instead of find).
woutermont
approved these changes
May 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.