Remove overly specific index-has-key constraint for link[@rel="proof-of-compliance"]#2103
Closed
aj-stein-gsa wants to merge 1 commit intousnistgov:developfrom
Closed
Conversation
Contributor
|
there are multiple issues with this constraint: this change will allow proof of compliance to be direct links as well as links to other components or the resources in the back-matter. I would say that validated by should be removed as well, OR a #{uuid} prefixing with a hash for continuity with other self referential component links. |
Contributor
Author
|
I am going to propose closing this PR in favor of the more narrowly scope constraint proposed #2107. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committer Notes
Proposed fix that closes #2102.
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)
Changes to Core Features:
Have you written new tests for your core changes, as applicable?Have you updated the OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the OSCAL-Pages and OSCAL_Reference repositories.N/A website documentation will be automatically updated from documentation generation pipeline.