fix: add creation date to consolidated profile PayloadDescription#679
Open
nancysangani wants to merge 4 commits into
Open
fix: add creation date to consolidated profile PayloadDescription#679nancysangani wants to merge 4 commits into
nancysangani wants to merge 4 commits into
Conversation
cspell.json: remove trailing comma
There was a problem hiding this comment.
Pull request overview
This PR fixes an inconsistency in generated configuration profiles by adding a Created: <date> prefix to the consolidated profile’s PayloadDescription, matching the format already used for domain-specific profiles (per Issue #678).
Changes:
- Add
Created: {date.today()}+ newline prefix to the consolidated profiledescriptioningenerate_profiles().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
Can you change the target of the PR to Tahoe? |
Author
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #678
The domain-specific profiles generated by
generate_profiles()correctly includeCreated: <date>in theirPayloadDescription, but the consolidated profile was missing it. Apply the samedate.today()format already used in the domain-specific profile description to keep them consistent.