Skip to content

ci: update node versions for cI#732

Merged
ctavan merged 3 commits intomainfrom
ci_node_20
Sep 8, 2023
Merged

ci: update node versions for cI#732
ctavan merged 3 commits intomainfrom
ci_node_20

Conversation

@broofa
Copy link
Copy Markdown
Member

@broofa broofa commented Sep 7, 2023

No description provided.

@broofa broofa mentioned this pull request Sep 7, 2023
Merged
2 tasks
@ctavan
Copy link
Copy Markdown
Member

ctavan commented Sep 8, 2023

I updated the branch protection to expect the 20.x check to pass instead of 12.x

@ctavan ctavan merged commit 462128b into main Sep 8, 2023
@ctavan ctavan deleted the ci_node_20 branch September 8, 2023 10:31
@ctavan
Copy link
Copy Markdown
Member

ctavan commented Sep 8, 2023

Uhm, maybe we should add back the 12.x test? Otherwise I think it would be technically a breaking change to release a new version, WDYT?

We should also update the README for Node 20.x support…

@broofa
Copy link
Copy Markdown
Member Author

broofa commented Sep 8, 2023

Uhm, maybe we should add back the 12.x test? Otherwise I think it would be technically a breaking change to release a new version, WDYT?

Hmm... good point. I'll add 12.x back in.

[Breadcrumb: link to the debate on whether this sort of thing constitutes a breaking change.]

That said, our node support policy is "supported node releases + 1 prior version", right? So with 16.x slated for premature end-of-life on Monday, we should be able to drop support for 12 & 14 at our leisure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ctavan ctavan ctavan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@broofa @ctavan