Skip to content

shuf: Tune performance for -i 1-1000000#10478

Merged
sylvestre merged 1 commit intouutils:mainfrom
oech3:cold
Jan 25, 2026
Merged

shuf: Tune performance for -i 1-1000000#10478
sylvestre merged 1 commit intouutils:mainfrom
oech3:cold

Conversation

@oech3
Copy link
Contributor

@oech3 oech3 commented Jan 25, 2026

Should split cgu=1 unrelated things from #10476 for shuf.

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/tail/retry is no longer failing!

@oech3 oech3 changed the title Preliminary for dropping releae-fast profile Preliminary for dropping release-fast profile Jan 25, 2026
@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/tail/retry is no longer failing!

@oech3 oech3 force-pushed the cold branch 2 times, most recently from 509b957 to 7c6235c Compare January 25, 2026 15:51
@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

@oech3 oech3 force-pushed the cold branch 2 times, most recently from d9de764 to eac7d0a Compare January 25, 2026 17:30
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 25, 2026

CodSpeed Performance Report

Merging this PR will improve performance by 17%

Comparing oech3:cold (f33df28) with main (c279ede)

Summary

⚡ 2 improved benchmarks
✅ 140 untouched benchmarks
⏩ 180 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation shuf_repeat_sampling[50000] 5.2 ms 4.7 ms +9.05%
Simulation shuf_lines[100000] 31.7 ms 27.1 ms +17%

Footnotes

  1. 180 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@oech3 oech3 changed the title Preliminary for dropping release-fast profile shuf: Prepare dropping release-fast profile Jan 25, 2026
@oech3
Copy link
Contributor Author

oech3 commented Jan 25, 2026

@blyxxyz Would you review this (without cgu=1)? I'm not familiar with shuf...

@oech3 oech3 marked this pull request as ready for review January 25, 2026 17:33
@sylvestre
Copy link
Contributor

the commit needs to explain the shuf change, not what you are trying to achieve

@oech3
Copy link
Contributor Author

oech3 commented Jan 25, 2026

the commit needs to explain the shuf change, not what you are trying to achieve

Is shuf: performance tuning OK?

@github-actions
Copy link

GNU testsuite comparison:

Note: The gnu test tests/dd/no-allocate is now being skipped but was previously passing.

@oech3 oech3 changed the title shuf: Prepare dropping release-fast profile shuf: Tune performance for -i 1-1000000 Jan 25, 2026
@github-actions
Copy link

GNU testsuite comparison:

Note: The gnu test tests/env/env-signal-handler is now being skipped but was previously passing.

@oech3 oech3 force-pushed the cold branch 2 times, most recently from 21ab5f6 to b7d04e2 Compare January 25, 2026 18:12
@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

Copy link
Contributor

@blyxxyz blyxxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre merged commit e061f8e into uutils:main Jan 25, 2026
131 of 132 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants