Skip to content

Re-enable unused_qualifications lint #10571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Xylphy wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Re-enable unused_qualifications lint #10571

Xylphy wants to merge 11 commits into from

Conversation

@Xylphy
Copy link
Contributor

@Xylphy Xylphy commented Jan 30, 2026

Summary
This PR re-activates the unused_qualifications lint by setting it back to warn in the lint config:

- #unused_qualifications = "warn" // TODO: fix warnings in uucore, then re-enable this lint
+ unused_qualifications = "warn"

Motivation
unused_qualifications had been commented out due to warnings in uucore. Those warnings have now been addressed, so we can restore the lint to catch future regressions.

Testing

  • Verified on Linux locally.
  • I haven’t tested on other platforms; CI should confirm if this passes

Notes
If CI reports platform-specific warnings or toolchain differences, I’ll follow up with fixes or adjust the lint scope as needed.

@Xylphy
clippy: Re-enable unused_qualifications
9e2a54b 
Currently tested in linux environment and wanted to test if this fails in CI
@github-actions
Copy link

github-actions bot commented Jan 30, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/follow-name (passes in this run but fails in the 'main' branch)

@sylvestre
Copy link
Contributor

sylvestre commented Jan 30, 2026

Some jobs are sad

@Xylphy
Copy link
Contributor Author

Xylphy commented Jan 30, 2026 •
edited
Loading

Hahahahahahaha mhmmm, I'll push a fix in a bit

@Xylphy Xylphy force-pushed the clippy/unused_qualifications branch from 670b9a3 to ad88105 Compare January 30, 2026 13:04
@github-actions
Copy link

github-actions bot commented Jan 30, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)

@Xylphy Xylphy force-pushed the clippy/unused_qualifications branch from c5d25d4 to a7a0347 Compare January 30, 2026 13:45
@Xylphy Xylphy marked this pull request as draft January 30, 2026 15:57
@github-actions
Copy link

github-actions bot commented Jan 30, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/basenc/bounded-memory is now passing!

1 similar comment
@github-actions
Copy link

github-actions bot commented Jan 30, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/basenc/bounded-memory is now passing!

@Xylphy Xylphy force-pushed the clippy/unused_qualifications branch from 651f901 to 40e53e4 Compare January 30, 2026 16:42
xtqqczze
xtqqczze reviewed Jan 30, 2026
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jan 30, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/basenc/bounded-memory is now passing!

1 similar comment
@github-actions
Copy link

github-actions bot commented Jan 30, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/basenc/bounded-memory is now passing!

@Xylphy Xylphy marked this pull request as ready for review January 30, 2026 18:02
@Xylphy Xylphy requested a review from xtqqczze January 30, 2026 18:02
@xtqqczze
Copy link
Contributor

xtqqczze commented Jan 30, 2026 

---- test_dd::test_bytes_suffix_recursive stdout ----
bin: "/home/runner/work/coreutils/coreutils/target/aarch64-unknown-linux-gnu/debug/coreutils"
run: /home/runner/work/coreutils/coreutils/target/aarch64-unknown-linux-gnu/debug/coreutils dd count=2Bx2 status=none
bin: "/home/runner/work/coreutils/coreutils/target/aarch64-unknown-linux-gnu/debug/coreutils"
run: /home/runner/work/coreutils/coreutils/target/aarch64-unknown-linux-gnu/debug/coreutils dd skip=2Bx2 status=none
bin: "/home/runner/work/coreutils/coreutils/target/aarch64-unknown-linux-gnu/debug/coreutils"
run: /home/runner/work/coreutils/coreutils/target/aarch64-unknown-linux-gnu/debug/coreutils dd iseek=2Bx2 status=none

thread 'test_dd::test_bytes_suffix_recursive' panicked at tests/uutests/src/lib/util.rs:412:35:
called `Option::unwrap()` on a `None` value

Looks like #10442

xtqqczze
xtqqczze reviewed Jan 30, 2026
View reviewed changes
xtqqczze
xtqqczze reviewed Jan 30, 2026
View reviewed changes
xtqqczze
xtqqczze reviewed Jan 30, 2026
View reviewed changes
xtqqczze
xtqqczze reviewed Jan 30, 2026
View reviewed changes
xtqqczze
xtqqczze reviewed Jan 30, 2026
View reviewed changes
@Xylphy Xylphy marked this pull request as draft January 30, 2026 19:09
xtqqczze
xtqqczze reviewed Jan 30, 2026
View reviewed changes
tests/by-util/test_mv.rs Outdated
// Verify content is preserved
assert_eq!(
std::fs::read_to_string(&moved_file1).expect("Failed to read moved file1"),
read_to_string(&moved_file1).expect("Failed to read moved file1"),
Copy link
Contributor

@xtqqczze xtqqczze Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I think fs::read_to_string would read better.

Copy link
Contributor Author

@Xylphy Xylphy Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xtqqczze I removed read_to_string from the import and use fs::read_to_string now. Should I also switch set_permissions/write to fs::… and just use std::fs?

Copy link
Contributor

@xtqqczze xtqqczze Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that would be preferable. Let's wait to see what other reviewers think.

Copy link
Contributor Author

@Xylphy Xylphy Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okayy

xtqqczze
xtqqczze reviewed Jan 30, 2026
View reviewed changes
@xtqqczze
Copy link
Contributor

xtqqczze commented Jan 30, 2026

Overall, the changes look fine to me, but since in some cases the qualification might have been added to improve readability, we should consider those instances carefully.

@Xylphy Xylphy force-pushed the clippy/unused_qualifications branch from e20765d to 4df9e71 Compare January 30, 2026 19:30
@Xylphy Xylphy force-pushed the clippy/unused_qualifications branch from 4df9e71 to ad00954 Compare January 30, 2026 19:35
@github-actions
Copy link

github-actions bot commented Jan 30, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.

@Xylphy Xylphy marked this pull request as ready for review January 30, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@xtqqczze xtqqczze xtqqczze left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Xylphy @sylvestre @xtqqczze @oech3 @dezgeg