shuf: Use rustc-hash for performance

[oech3]

No description provided.

[codspeed-hq]

CodSpeed Performance Report

Merging this PR will improve performance by 31.56%

_{Comparing oech3:shufxxh3 (f856a46) with main (61da637)}

Summary

⚡ 1 improved benchmark
✅ 141 untouched benchmarks
⏩ 180 skipped benchmarks¹

Performance Changes

	Mode	Benchmark	BASE	HEAD	Efficiency
⚡	Simulation	shuf_input_range[1000000]	126.4 ms	96.1 ms	+31.56%

Footnotes

1. 180 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

[sylvestre]

please fix the typo in the commit message
'performance'

[oech3]

Fixed. Sorry...

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

[ChrisDryden]

IIRC the shuf/shuf-reservoir gnu test is failing because the implementation was slower than the GNU test and would sometimes timeout on high cpu load, would be interesting to see if this removed the test flakiness for that test.

[oech3]

It does not run shuf -i 1-HUGE_NUM.

[oech3]

Do you think that we should change hash algo for (t)sort to xxh3 or other?

[xtqqczze]

rustc-hash is a "non-cryptographic hashing algorithm". Is resistance against collisions a concern for shuf?

[oech3]

Is HashMap used for file names directly? It might able to fallback to default hash func for files on network.

[oech3]

not SipHash?

[xtqqczze]

not SipHash?

Yes the standard library does in fact use SipHasher13, the documentation for hashbrown is misleading ( rust-lang/hashbrown#153)