Access mode changes for Unique copyback output#2558
Open
danhoeflinger wants to merge 1 commit intodev/dhoeflin/align_write_no_initfrom
Open
Access mode changes for Unique copyback output#2558danhoeflinger wants to merge 1 commit intodev/dhoeflin/align_write_no_initfrom
danhoeflinger wants to merge 1 commit intodev/dhoeflin/align_write_no_initfrom
Conversation
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
danhoeflinger
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #2519, this PR changes the copyback operation of
pattern_uniqueoutput buffer to the defaultwritewithno_initrather thanread_writewithoutno_init. This allows us to skip the unnecessary copy-in for the output buffer.