More changes related to unique_copy and copy_if#2561
Merged
Conversation
akukanov
force-pushed
the
dev/cosmetic-changes-akukanov
branch
2 times, most recently
from
02ffa9c to
9bf68f0
Compare
akukanov
changed the title
akukanov
changed the title
akukanov
force-pushed
the
dev/cosmetic-changes-akukanov
branch
2 times, most recently
from
185e596 to
1095484
Compare
akukanov
force-pushed
the
dev/cosmetic-changes-akukanov
branch
from
1095484 to
06fd708
Compare
akukanov
force-pushed
the
dev/cosmetic-changes-akukanov
branch
4 times, most recently
from
69e2ace to
1d2f38c
Compare
akukanov
changed the title
akukanov
force-pushed
the
dev/cosmetic-changes-akukanov
branch
2 times, most recently
from
9e09683 to
14c4c11
Compare
akukanov
force-pushed
the
dev/cosmetic-changes-akukanov
branch
from
dbcdacf to
14c4c11
Compare
akukanov
force-pushed
the
dev/cosmetic-changes-akukanov
branch
from
3619f53 to
6206344
Compare
akukanov
force-pushed
the
dev/cosmetic-changes-akukanov
branch
4 times, most recently
from
235afae to
0abfa48
Compare
| auto __lacc = __dpl_sycl::__local_accessor<_ValueType>(sycl::range<1>(__n_uniform * 2 + 1), __hdl); | ||
| auto __res_acc = __get_accessor(sycl::write_only, __result, __hdl, __dpl_sycl::__no_init{}); | ||
| std::uint16_t __wg_size = static_cast<std::uint16_t>(std::min(__n_uniform, __max_wg_size)); | ||
|
|
SergeyKopienko
previously approved these changes
Feb 10, 2026
Contributor
SergeyKopienko
left a comment
SergeyKopienko
left a comment
There was a problem hiding this comment.
LGTM
- one small comment - up to you.
akukanov
force-pushed
the
dev/cosmetic-changes-akukanov
branch
from
0abfa48 to
78b181a
Compare
| return true; | ||
| } | ||
| else | ||
| static_assert(std::is_signed_v<_IndexTp>); |
Contributor
There was a problem hiding this comment.
May be nice to have a text message here.
danhoeflinger
approved these changes
Feb 10, 2026
Contributor
danhoeflinger
left a comment
danhoeflinger
left a comment
There was a problem hiding this comment.
LGTM, minor comment you can fix if you want.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
walk_n<oneapi::dpl::identity>; use where appropriate__pstl_assignin the copy_if call chain__create_mask_unique_copywith__create_maskusing the index predicatesBinaryOpparameter (which was always std::plus) fromcopy_/partition_by_mask__parallel_copy_if_single_group_functor