feat: add signal bind methods to checkbox component#8732
Open
feat: add signal bind methods to checkbox component#8732
Conversation
DiegoCardoso
requested changes
Feb 19, 2026
Contributor
DiegoCardoso
left a comment
DiegoCardoso
left a comment
There was a problem hiding this comment.
Let's fix the javadoc for the new API.
Comment on lines
+355
to
+366
| /** | ||
| * Binds the indeterminate state to the given writable signal. The binding | ||
| * is two-way: signal changes push to the DOM property, and client-side | ||
| * property changes push back to the signal. | ||
| * <p> | ||
| * While a signal is bound, any attempt to set the indeterminate state | ||
| * manually throws {@link com.vaadin.flow.signals.BindingActiveException}. | ||
| * | ||
| * @param signal | ||
| * the writable signal to bind, not {@code null} | ||
| * @since 25.1 | ||
| */ |
DiegoCardoso
approved these changes
Feb 19, 2026
sissbruecker
requested changes
Feb 20, 2026
Contributor
There was a problem hiding this comment.
We don't have any other signal test that is named just for a single property, so this one probably shouldn't be either.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.