refactor!: update MasterDetailLayout API to match web component changes#8952
Merged
web-padawan merged 5 commits intomainfrom Mar 20, 2026
Merged
refactor!: update MasterDetailLayout API to match web component changes#8952web-padawan merged 5 commits intomainfrom
web-padawan merged 5 commits intomainfrom
Conversation
web-padawan
changed the title
vursen
reviewed
Mar 18, 2026
...-flow/src/test/java/com/vaadin/flow/component/masterdetaillayout/MasterDetailLayoutTest.java
Show resolved
Hide resolved
Remove API that no longer exists in the web component (setForceOverlay, setOverlayMode/OverlayMode, masterMinSize, detailMinSize), rename Containment to OverlayContainment, and add new overlaySize and expand properties. Update Javadoc and tests accordingly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add constructor MasterDetailLayout(String masterSize, String detailSize, Expand expandingSide) for convenient initialization. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Rename Expand enum to ExpandingArea, setExpand/getExpand to setExpandingArea/getExpandingArea. Add constructor with float sizes and units: MasterDetailLayout(float, Unit, float, Unit, ExpandingArea). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
web-padawan
force-pushed
the
refactor/mdl-2.0
branch
from
ebe33e1 to
74573c8
Compare
vursen
reviewed
Mar 18, 2026
Comment on lines
+125
to
+126
| public MasterDetailLayout(float masterSize, Unit masterUnit, | ||
| float detailSize, Unit detailUnit, ExpandingArea expandingArea) { |
Contributor
There was a problem hiding this comment.
Looking at other components, none of them seem to have constructors with unit parameters. I think a constructor taking String masterSize and String detailSize should be enough?
Member
Author
There was a problem hiding this comment.
@rolfsmeds explicitly requested adding this option on the thread 😅 I don't have a strong opinion.
Contributor
There was a problem hiding this comment.
Yeah, I dunno, maybe it's overkill?
vursen
approved these changes
Mar 19, 2026
Member
Author
|
Let's wait until WC 25.2.0-alpha1 to be released before merging this PR. |
rolfsmeds
approved these changes
Mar 20, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes vaadin/web-components#11345
Fixes vaadin/web-components#11346
Fixes vaadin/web-components#11347
setForceOverlay/isForceOverlay,setOverlayMode/getOverlayMode/OverlayModeenum,masterMinSize, anddetailMinSizepropertiesContainmentenum toOverlayContainmentand update getter/setter (overlayContainmentelement property)overlaySizeproperty (size of detail area when shown as overlay)Expandenum andexpandproperty (controls which area(s) fill available space)CategoryView) to use new APITest plan
mvn test -pl vaadin-master-detail-layout-flow-parent/vaadin-master-detail-layout-flow)🤖 Generated with Claude Code