Open
Conversation
|
tomivirkki
reviewed
Mar 19, 2026
| "time", "timestamp", "datetime"); | ||
|
|
||
| @Override | ||
| public List<Series> convertToSeries(List<Map<String, Object>> data) { |
Member
There was a problem hiding this comment.
"series" is a pretty common column name — e.g. a table tracking TV shows could easily have a series column for the show name. Consider using something more specific to avoid accidental collisions with real data columns.
Comment on lines
+120
to
+121
| private static final List<String> X_COLUMN_NAMES = List.of("x", "date", | ||
| "time", "timestamp", "datetime"); |
Member
There was a problem hiding this comment.
Is it necessary to have all these options for the x-column name? I'd assume we can make the system prompt use a consistent column name for x.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Adds
DefaultDataConverterthat supports 15 chart type patterns via column-name-based detection, plus a fallback for basic charts.DefaultDataConvertersupportsseriescolumnThe patterns checked:
Fixes https://github.com/orgs/vaadin/projects/103/views/1?filterQuery=&pane=issue&itemId=165657712
Type of change
Checklist