consider alternative strategy for removing the tokenfile in maven plugin

[jorgheymans]

Sort of reported here .

In this fix the flow-build-info.json token file was scheduled to be deleted on jvm exit. However, there are things like mvnd, which keeps maven instances around for faster build times. In such case, the jvm does not exit, and the tokenfile remains present.

Maybe there are other scenario's. The intellij plugin could be more defensive about that file, or the tokenFile deletion gets handled differently.

[jorgheymans]

Note that maven4 will have mvnsh , so it would be fair to assume that more people are going to be impacted by this.

https://maven.apache.org/whatsnewinmaven4.html

With Maven 4, you can also take advantage of the newly defined “Maven Shell” (mvnsh), which keeps a single Maven process running for as long as the shell remains open.

[jorgheymans]

With the new recommended maven configuration in v25 (no more profile for production builds) we are hitting this issue more now. Developers do a maven build in commandline (using mvnd which keeps instances around), and sometime later start the application using IntelliJ Vaadin plugin. The application is then started in production mode instead of debug mode because the tokenfile is still around.

deleteOnExit should not be relied upon in a maven plugin.

[mcollovati]

#23945 is an attempt to fix this issue.
It hooks into the Maven lifecycle and removes the file at the end of the build, after all plugins have run.
However, this needs the plugin to be configured in the project with <extensions>true</extensions>.
The deleteOnExit is not removed, so existing projects will still behave correctly when not using mvnd.

For mvnd, the compromise is to add the <extensions>true</extensions> configuration to the Vaadin maven plugin declaration.