refactor: Convert use-local-web-components to TS#23829
Merged
Conversation
Replace the plain JS module with a proper Vite plugin that returns a plugin config object. Also bump the Vite peer dependency to 7.x for the service-worker and local-web-components plugins. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
vursen
changed the title
Replace the plain JS module with a proper Vite plugin that returns a plugin config object. Also bump the Vite peer dependency to 7.x for the service-worker and local-web-components plugins. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
vursen
requested review from
Artur- and
platosha
and removed request for
Artur-
Artur-
approved these changes
Mar 13, 2026
Collaborator
|
Hi @vursen and @Artur-, when i performed cherry-pick to this commit to 25.1, i have encountered the following issue. Can you take a look and pick it manually? |
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 13, 2026
Replace the plain JS module with a proper TS Vite plugin that returns a plugin config object. Also bump the Vite peer dependency to 7.x for the service-worker and local-web-components plugins.
vaadin-bot
added a commit
that referenced
this pull request
Mar 13, 2026
Replace the plain JS module with a proper TS Vite plugin that returns a plugin config object. Also bump the Vite peer dependency to 7.x for the service-worker and local-web-components plugins. Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the plain JS module with a proper TS Vite plugin that returns a plugin config object. Also bump the Vite peer dependency to 7.x for the service-worker and local-web-components plugins.