Add nullSafeConverter method to Converter interface#23946
Draft
Add nullSafeConverter method to Converter interface#23946
Conversation
|
Member
Author
|
Converting back to draft. This needs some more work with regards to empty values. For some fields, the empty value is not null. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
When writing converters, there are already methods provided for using mapper functions that map between the model and presentation values. This is useful, but these functions, like
LocalDate::parseorLocalDate::toStringalways assume a non-null input. Since converters work with both null inputs and outputs, you virtually always have to write your own custom validators to handle nulls.This helper function allows you to write converters like this:
Type of change