refactor: surface color computation#11536
Merged
Merged
Conversation
71ed8e7 to
001e68a
Compare
d02ead1 to
5633f7e
Compare
web-padawan
approved these changes
Apr 23, 2026
|
Collaborator
|
This ticket/PR has been released with Vaadin 25.2.0-alpha4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



For light mode, make the step from surface level 0 to level 1 more gradual, so that it doesn't turn to pure white as quickly, allowing level 1 and level 2 be more distinct.
Tweak the accent surface color so that it more closely follows the brightness of the regular surface color.
Before vs after:
