Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Workspace rename currently fails in common emoji-entry flows. When users open the macOS emoji picker (
Ctrl+Cmd+Space) while renaming a workspace, the field can lose focus and the edit gets canceled instead of saved.This change allows workspace renames to commit on focus loss (while still cancelling on explicit cancel movement), so emoji characters can be inserted and persisted reliably.
Root Cause
Workspace inline rename logic only committed when editing ended with
NSReturnTextMovement.Any other end-editing movement was treated as cancel, which includes focus changes that happen during emoji picker interactions.
Changes
commitsOnFocusLossbehavior to/Users/vaibhavsomani/Desktop/Projects/personal/arcmark/Sources/ArcmarkCore/Components/Base/InlineEditableTextField.swift.commitsOnFocusLossfor workspace rows in/Users/vaibhavsomani/Desktop/Projects/personal/arcmark/Sources/ArcmarkCore/WorkspaceRowView.swift./Users/vaibhavsomani/Desktop/Projects/personal/arcmark/Sources/ArcmarkCore/WorkspaceSwitcherView.swiftto commit on non-cancel focus-loss events.User Impact
Validation
swift build -c release./scripts/run.sh./scripts/verify-build.sh .build/bundler/Arcmark.apposascript -e 'application "Arcmark" is running'returnedtrue