feat(isRFC3339): Disallow prepended and appended strings to RFC 3339 date-time#1654
Merged
profnandaa merged 1 commit intovalidatorjs:masterfrom Apr 21, 2021
Merged
feat(isRFC3339): Disallow prepended and appended strings to RFC 3339 date-time#1654profnandaa merged 1 commit intovalidatorjs:masterfrom
profnandaa merged 1 commit intovalidatorjs:masterfrom
Conversation
Fixes validatorjs#1653 Also adds corresponding test cases to ISO 8601 validator
jmacmahon
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1654 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 101 101
Lines 1854 1854
=========================================
Hits 1854 1854
Continue to review full report at Codecov.
|
tux-tn
approved these changes
Apr 21, 2021
Member
tux-tn
left a comment
tux-tn
left a comment
There was a problem hiding this comment.
That was fast! Thank you @jmacmahon and congrats for your first PR here 🎉
tux-tn
added
ready-to-land
profnandaa
approved these changes
Apr 21, 2021
Member
profnandaa
left a comment
profnandaa
left a comment
There was a problem hiding this comment.
LGTM. Thanks and welcome to the project!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1653
Adds test cases for invalid RFC 3339 strings as valid
date-timestrings, but prepended and appended with the word "nonsense".Also adds equivalent test cases for ISO 8601 validator (but did not change the implementation as it was already OK).
Checklist