Refactor assertString: Faster, less nested and more consistent.#2372
Refactor assertString: Faster, less nested and more consistent.#2372rubiin merged 5 commits intovalidatorjs:masterfrom
Conversation
WikiRik
left a comment
There was a problem hiding this comment.
I think the tests are failing because we currently do not throw an error for '' (an empty string).
Also; can you commit the unit tests as well?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2372 +/- ##
==========================================
- Coverage 99.95% 99.95% -0.01%
==========================================
Files 107 107
Lines 2454 2445 -9
Branches 619 617 -2
==========================================
- Hits 2453 2444 -9
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi, @WikiRik! |
|
codecov/project will be fixed with #2341 |
|
when you pass literally because it is not caught by the first check. Should we explicitly check for null there as well? |
|
Hello, @pano9000! |
pano9000
left a comment
There was a problem hiding this comment.
should be ok now :-)
(however my approval is rather useless, as I am not a maintainer)

@profnandaa,
I have a possible improvement for the assertString.
I am reducing the number of necessary validations and also a more assertive approach, in my point of view (if this approach doesn't make sense, I would appreciate feedback on it, if possible).
The performance has also improved, it wasn't something incredible, but it was considerable.
Unit tests:
