Combined configuration and task creation for targets

[gabrielittner]

The configuration looks like this:

mavenPublish {
  // these 4 are equivalent to configuring `targets.upload` below
  releaseRepositoryUrl = "..." 
  snapshotRepositoryUrl = "..."
  repositoryUsername = "..."
  repositoryPassword = "..."
            
  targets {
	upload {
	  // configures the default uploadArchives
      releaseRepositoryUrl = "..." 
	}

	install {
	  // configures the default installArchives
	}

    otherRepo {
      // creates new upload task called `uploadArchivesOtherRepo`
    }
  }
}

[codecov]

Codecov Report

Merging #25 into multiple-repos will increase coverage by 7.99%.
The diff coverage is 79.31%.

@@                 Coverage Diff                  @@
##             multiple-repos      #25      +/-   ##
====================================================
+ Coverage             82.17%   90.16%   +7.99%     
+ Complexity               16       13       -3     
====================================================
  Files                     4        3       -1     
  Lines                   129      122       -7     
  Branches                 12       15       +3     
====================================================
+ Hits                    106      110       +4     
+ Misses                   18        5      -13     
- Partials                  5        7       +2

Impacted Files	Coverage Δ	Complexity Δ
...com/vanniktech/maven/publish/MavenPublishTarget.kt	85.71% <50%> (-14.29%)	3 <0> (ø)
...vanniktech/maven/publish/MavenPublishPlugin.groovy	93.87% <76.47%> (+4.98%)	6 <3> (+3)	⬆️
...ktech/maven/publish/MavenPublishPluginExtension.kt	70.58% <90%> (+5.88%)	4 <1> (-5)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acebcad...056600a. Read the comment docs.

[vanniktech]

I like it

[vanniktech]

[MavenPublishTargets][MavenPublishTarget] isn't one enough?

[gabrielittner]

The first one is what you see in when the markdown is rendered the second is the link to the class. I personally prefer that over writing [MavenPublishTarget]s

[vanniktech]

why do we need to specify the second parameter of MavenPublishTarget?

[gabrielittner]

I didn't want to make releaseRepositoryUrl nullable so it's needs something when initializing it. Nullable and then throwing later during configuration is probably better though.

[gabrielittner]

fixed d519b32

[vanniktech]

Should we rename upload to uploadArchives and uploadArchives to installArchives to have symmetry and matching names?

Probably also worth nuking the previous configuration parameters:

  releaseRepositoryUrl = "..." 
  snapshotRepositoryUrl = "..."
  repositoryUsername = "..."
  repositoryPassword = "..."

I doubt much people used them anyways.

[gabrielittner]

If we rename those two, should we also use the name of additional targets directly as task name?

[vanniktech]

Had a typo above that I corrected.

should we also use the name of additional targets directly as task name?

I don't quite understand what you mean. Do you have an example?

[gabrielittner]

The sample configuration above would result in these tasks uploadArchives, installArchives and uploadArchivesOtherRepo, because currently new targets are named "uploadArchives" + target.name. When we use the task names of the first two directly it would make sense to use target.name directly as task name.

[gabrielittner]

I've renamed install and upload. The task name for additional targets should be fine as it is. I think we're good to go now.

[vanniktech]

Yup looking good. Can be merged.

Before merging this feature into master itself, I'll mull over it a bit though. (I assume everything will go back to #23 right? Can also be a different PR though. Not strongly opinionated.)

[gabrielittner]

Either @budius merges the multiple-repos branch into his to update the existing PR or we create a new one.