Refactor code#101
Merged
Merged
Conversation
The class should handle the caching later and everything that comes with.
The functions add(_ :) and render(_ :) can be simplified. Therefore the view requirements have to be removed.
Brings back the briefly removed methods and mark them as deprecated.
The class should handle the localization later and everything that comes with it.
The draw attribute on the group element is incorrect. It should be removed.
It reduces the code redundancy, plus each node is one single ingredient in the renderer formula.
The converter doesn't use it anymore.
The html context class is slightly the same. While the html context is more used, the context variable file can be removed.
The access level for the comparison operators stays public.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge brings some changes:
Code adjustments
There will be some syntax and logic changes. The old syntax is marked as deprecated, so it still can be used, but should be changed in the future.
Untouched files
Some files will be removed, as I couldn't see any use of them. All checks have passed. I guess we should be fine.
Folder Structure
The folder structure will be rearranged. There will be two folders:
Abstraction
The folder contains the HTML abstraction.
Framework
The folder contains the files for the framework.
New tests
There will be new tests for the statements and the conditions. They had been missing. With the tests we get sure, that the upcoming changes will not effect the directives.