LoggerFragmentBuilder#221
Merged
fpseverino merged 30 commits intovapor:consolekit-5from Nov 3, 2025
fpseverino:logger-fragment-builder
Merged
LoggerFragmentBuilder#221fpseverino merged 30 commits intovapor:consolekit-5from fpseverino:logger-fragment-builder
fpseverino merged 30 commits intovapor:consolekit-5from
fpseverino:logger-fragment-builder
Conversation
Co-authored-by: Gwynne Raskind <gwynne@darkrainfall.org>
Co-authored-by: Gwynne Raskind <gwynne@darkrainfall.org>
Co-authored-by: Gwynne Raskind <gwynne@darkrainfall.org>
Co-authored-by: Gwynne Raskind <gwynne@darkrainfall.org>
Co-authored-by: Gwynne Raskind <gwynne@darkrainfall.org>
Co-authored-by: Gwynne Raskind <gwynne@darkrainfall.org>
Co-authored-by: Gwynne Raskind <gwynne@darkrainfall.org>
Co-authored-by: Gwynne Raskind <gwynne@darkrainfall.org>
Co-authored-by: Gwynne Raskind <gwynne@darkrainfall.org>
Co-authored-by: Gwynne Raskind <gwynne@darkrainfall.org>
Co-authored-by: Gwynne Raskind <gwynne@darkrainfall.org>
semicoleon
approved these changes
Nov 1, 2025
Contributor
semicoleon
left a comment
semicoleon
left a comment
There was a problem hiding this comment.
Other than the one minor stylistic point (which I don't feel strongly about) I think this looks fine. Special casing spaces in LoggerSpacedFragmentBuilder feels slightly unfortunate but I think that's just a limitation of the result builder system and would be hard enough to work around that it probably isn't worth it
Sources/ConsoleLogger/LoggerFragments/LoggerSpacedFragmentBuilder.swift
Outdated
Show resolved
Hide resolved
Member
Author
Yeah, I haven't been able to find a better way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a DSL to build
LoggerFragments