Skip to content

Use suspending clock in ActivityIndicator#228

Merged
fpseverino merged 2 commits intoconsolekit-5from
activity-indicator
Jan 20, 2026
Merged

Use suspending clock in ActivityIndicator#228
fpseverino merged 2 commits intoconsolekit-5from
activity-indicator

Conversation

@fpseverino
Copy link
Member

@fpseverino fpseverino commented Jan 20, 2026 •
edited
Loading

  • Use suspending clock in ActivityIndicator as it is more appropriate then the continuous one for updating UI
  • Add test to check if task cancellation is respected in withActivityIndicator

@gwynne gwynne changed the title Use supsending clock in ActivityIndicator Use suspending clock in ActivityIndicator Jan 20, 2026
@fpseverino fpseverino merged commit 893bbaf into consolekit-5 Jan 20, 2026
13 checks passed
@fpseverino fpseverino deleted the activity-indicator branch January 20, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gwynne gwynne gwynne approved these changes

@0xTim 0xTim Awaiting requested review from 0xTim 0xTim is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fpseverino @gwynne